Skip to content

fixed typo #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fixed typo #6998

wants to merge 1 commit into from

Conversation

jermenkoo
Copy link

@jermenkoo jermenkoo commented Oct 13, 2016

Fixed #6994

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 13, 2016

CLA assistant check
All committers have signed the CLA.

@shanevbg
Copy link

#6994 was not a real typo, both spellings are correct!
http://grammarist.com/spelling/cancel/
In American English, the verb cancel is usually inflected canceled and canceling—with one l. This is not a rule, however, and exceptions are easily found. In varieties of English from outside the U.S., including Canadian, British, and Australian English, cancelled and cancelling are the preferred spellings.

@jermenkoo
Copy link
Author

I would claim that we should try to be consistent as well. (even though is a minor, negligible issue).

@shanevbg
Copy link

Just pointing out that Americans will complain that it's a typo after you fix it for other countries. Much like colour and color. If the goal is to use British spellings everywhere then you should be consistent.
http://grammarist.com/spelling/color-colour/
Color and colour are different spellings of the same word. Color is the preferred spelling in American English, and colour is preferred in all other main varieties of English.

Copy link

@shanevbg shanevbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "fixing" this will cause confusion. It would be better to create a language pack for GB_eng

@almarchenko
Copy link

@jermenkoo Thanks for your input! We will discuss the best solution and let you know!

@okorshenko okorshenko self-assigned this Mar 11, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 11, 2017
@okorshenko
Copy link
Contributor

@jermenkoo Thank you for your contribution.
After several internal discussions, we agreed to keep Americal English variant of this word. Closing this PR

@okorshenko okorshenko closed this Mar 12, 2017
@magento magento locked and limited conversation to collaborators Mar 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants